Rewrite lambdas to method references for instance methods #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
4 tasks
|
Nice, we should test this on a large internal project before merging. I found a lot of bugs in the original implementation that way! |
carterkozak
reviewed
May 28, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LambdaMethodReference.java
Outdated
Show resolved
Hide resolved
…prone/LambdaMethodReference.java Co-authored-by: Carter Kozak <ckozak@ckozak.net>
`Optional<String>::toString` does not compile
carterkozak
approved these changes
May 28, 2020
|
Everything is green. |
|
Needs an approval from you as well since my commits merged into this branch :-) |
|
woohooo 👍 |
|
🤖 |
|
Released 3.16.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We would only re-write lambdas with zero parameters that invoked static methods to method references
After this PR
==COMMIT_MSG==
Rewrite single parameter lambdas that only invoke an zero param instance method to a method reference
==COMMIT_MSG==
Possible downsides?
N/A