Upgrade gradle-errorprone

[ferozco]

Before this PR

We had blocked upgrades of gradle-errorprone because we were worried about forcing a "high" dependency on gradle (5.2). Since then gradle has released a bunch and the fleet has been keeping up to date so we no longer have to be worried about the dependency.

After this PR

==COMMIT_MSG==
Upgrade gradle-errorprone
==COMMIT_MSG==

Possible downsides?

N/A

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Upgrade gradle-errorprone

Check the box to generate changelog(s)

• Generate changelog entry

[robert3005]

errorProneArgs is now a property so you can't do https://github.com/palantir/gradle-baseline/blob/develop/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineErrorProneIntegrationTest.groovy#L173

[ferozco]

Ya I noticed :( its quite unfortunate since its pretty common for people to configure checks that way. I think we may want to hold off on merging this until we have a replacement. My current thoughts are to propose the following to the upstream plugin:

tasks.withType(JavaCompile) {
  options.errorprone.check 'OptionalOrElseMethodInvocation', 'OFF'
}

Eh, actually looking at it they already expose pretty nice methods configuring checks. ex:

gradle-baseline/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineErrorProneIntegrationTest.groovy

Line 173 in d039b4b

options.errorprone.disable 'OptionalOrElseMethodInvocation'

[robert3005]

yeah, I think current version of the plugin has nice apis. Just the original version only really had the array based method and we stuck to it.