Improvement: Add error-prone check that forbids extending java.lang.Error #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2020 21:19
carterkozak
reviewed
Jun 2, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/ExtendsError.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Jun 2, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/ExtendsError.java
Outdated
Show resolved
Hide resolved
added 2 commits
June 2, 2020 23:29
ferozco
reviewed
Jun 3, 2020
...line-error-prone/src/main/java/com/palantir/baseline/errorprone/ExtendsErrorOrThrowable.java
Show resolved
Hide resolved
|
👍 |
dansanduleac
approved these changes
Jun 3, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We would allow extending Error. While there are niche cases where this is useful in vast majority of cases it can lead to more confusing and bugs than value.
After this PR
==COMMIT_MSG==
Add error-prone check that forbids extending java.lang.Error (reports ERROR). Provides a fix to replace
extends Errorwithextends RuntimeExceptionfor clearer contract to the consumers.==COMMIT_MSG==
Possible downsides?
The refactoring will get applied automatically but it might require human attention to merge. Cases where people would
} catch (Error e) {are what we want to fix so those who do that might require to adjust their catch clauses after libraries pick up this check.