Don't include SUGGESTION checks in default checks

[pkoenig10]

When new SUGGESTION checks are added, it adds noise to the compiler output.

Even if these checks have suggested fixes, there is nothing that enforces SUGGESTION checks. So subsequent changes can introduce regressions that clutter the compiler output.

As a result I've found myself adding the config like this to all our repos to ensure that we enforce the default patch checks when new SUGGESTION checks are added.

options.errorprone.errorproneArgs += [
    '-Xep:AssertjRefactoring:WARN',
    '-Xep:CatchSpecificity:WARN',
    '-Xep:LambdaMethodReference:WARN',
    '-Xep:PreferAssertj:WARN',
    '-Xep:PreferCollectionConstructors:WARN',
    '-Xep:PreferBuiltInConcurrentKeySet:WARN',
    '-Xep:RedundantMethodReference:WARN',
    '-Xep:RedundantModifier:WARN',
    '-Xep:StreamOfEmpty:WARN',
    '-Xep:ThrowSpecificity:WARN']

Relying on excavator upgrades to fix these results in code churn and doesn't seem like the right approach. I'd would strongly prefer to either:

1. Enforce these checks at the warning level so projects can opt-in to failing at compile time for all new checks using -Werror.
2. Don't include SUGGESTION checks in default checks.

This PR takes approach (1), but I'm indifferent between these two options (or some mix of them depending on the check).

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

The baseline-error-prone plugin no longer applies SUGGESTION checks by default.

Check the box to generate changelog(s)

• Generate changelog entry

[ferozco]

Overall supportive of making these checks (especially since most autofix) warning/errors

[ferozco]

seems like this should be an error

[carterkozak]

I think we want WARN here, iirc we use a flag to ignore error-prone warnings in generated code but it doesn't apply to errors.

[ferozco]

I believe we explicitly opt out of errorprone on generated source sets:

gradle-baseline/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java

Line 210 in a63a0ad

.set(String.format(

[pkoenig10]

Can we change this in a FLUP? I'd prefer not to accidentally break things in this PR.

[carterkozak]

+1 for handling warn->error separately. I don't think our regex catches 100% of generated code and I'm not sure it's worth the risk breaking some folks in order to fail builds in repos that don't fail on errors

[ferozco]

same here, definitely a bug

[pkoenig10]

I think the risk with making some of these errors is that repos which have a bunch of existing violation will be blocked. WARNING seems a bit safer because it's won't fail compilation unless you have -Werror.

Happy to change it if you would still prefer ERROR, just wanted to point this out.

[ferozco]

in practice these rules will be auto applied on upgrade so I'm not particularly worried about blocking upgrades.

[ferozco]

👍

[svc-autorelease]

Released 3.20.0