Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--write-locks no longer implicitly runs checkClassUniqueness task #1389

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

iamdanfox
Copy link
Contributor

Before this PR

I've become frustrated with how the local experience of writing ./gradlew --write-locks has become very slow. This is often because checkClassUniqueness is a pretty meaty task, which ends up analyzing all jars on the classpath.

After this PR

==COMMIT_MSG==
Running ./gradlew --write-locks should be faster now, as it doesn't update your baseline-class-uniqueness.lock file implicitly anymore. To update this, you need to run ./gradlew checkClassUniqueness --write-locks.
==COMMIT_MSG==

Possible downsides?

A big downside here is: if we just merge this PR, then a bunch of excavators will probably start opening PRs with out of date baseline-class-uniqueness.lock files, leading to frustrated devs.

@changelog-app
Copy link

changelog-app bot commented Jun 3, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Running ./gradlew --write-locks should be faster now, as it doesn't update your baseline-class-uniqueness.lock file implicitly anymore. To update this, you need to run ./gradlew checkClassUniqueness --write-locks.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from dansanduleac June 3, 2020 22:57
@iamdanfox iamdanfox force-pushed the dfox/faster-write-locks branch from af677fa to 57ef7b4 Compare June 3, 2020 22:58
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like our error message already suggests checkClassUniqueness --write-locks 👍

@bulldozer-bot bulldozer-bot bot merged commit 09ca77a into develop Jun 11, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/faster-write-locks branch June 11, 2020 20:17
@svc-autorelease
Copy link
Collaborator

Released 3.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants