-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--write-locks no longer implicitly runs checkClassUniqueness task #1389
Conversation
Generate changelog in
|
af677fa
to
57ef7b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like our error message already suggests checkClassUniqueness --write-locks
👍
Released 3.24.0 |
Before this PR
I've become frustrated with how the local experience of writing
./gradlew --write-locks
has become very slow. This is often because checkClassUniqueness is a pretty meaty task, which ends up analyzing all jars on the classpath.After this PR
==COMMIT_MSG==
Running
./gradlew --write-locks
should be faster now, as it doesn't update yourbaseline-class-uniqueness.lock
file implicitly anymore. To update this, you need to run./gradlew checkClassUniqueness --write-locks
.==COMMIT_MSG==
Possible downsides?
A big downside here is: if we just merge this PR, then a bunch of excavators will probably start opening PRs with out of date baseline-class-uniqueness.lock files, leading to frustrated devs.