Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PreferStaticLoggers error-prone check #1446

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Implement PreferStaticLoggers error-prone check #1446

merged 3 commits into from
Jul 8, 2020

Conversation

carterkozak
Copy link
Contributor

Before this PR

No easy migration path for existing projects with instance loggers.

After this PR

==COMMIT_MSG==
Implement PreferStaticLoggers error-prone check
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Jul 5, 2020 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Implement PreferStaticLoggers error-prone check

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from dansanduleac July 5, 2020 17:32
iamdanfox
iamdanfox approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the sandman is OOTO

@ferozco
Copy link
Contributor

ferozco commented Jul 8, 2020

🤖

@bulldozer-bot bulldozer-bot bot merged commit daaf9c7 into develop Jul 8, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/prefer_static_loggers branch July 8, 2020 00:54
This was referenced Jun 22, 2021
Closed
Closed
Merged
Closed
Open
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@dansanduleac dansanduleac Awaiting requested review from dansanduleac

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carterkozak @ferozco @iamdanfox