Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in TooManyArguments check #1449

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Fix typo in TooManyArguments check #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85166d0
Fix typo in TooManyArguments check
mnazbro Jul 8, 2020
1f6446b
Add generated changelog entries
mnazbro Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/TooManyArguments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public Description matchMethod(MethodTree tree, VisitorState state) {
if (tree.getParameters().size() > MAX_NUM_ARGS) {
return buildDescription(tree)
.setMessage("Interfaces can take at most " + MAX_NUM_ARGS
+ " arguments. Consider the following ways of soling the problem:\n"
+ " arguments. Consider the following ways of solving the problem:\n"
+ "- Define an object with Immutables that contains all of the arguments\n"
+ "- Expose smaller interfaces by refactorings concepts into separate interfaces")
.build();
Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1449.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Fix typo in TooManyArguments check
links:
- https://github.com/palantir/gradle-baseline/pull/1449