checkstyle 8.36 -> 8.37 (and keep it up to date using excavator) #1546
Conversation
Generate changelog in
|
|
|
||
| if (gradle.startParameter.isWriteDependencyLocks()) { | ||
| gradle.startParameter.taskNames += 'writeCheckstyleVersion' | ||
| } |
There was a problem hiding this comment.
an alternative approach here is to generate the resource just-in-time as a dependency of the ./gradlew idea task... no super strong opinions, i just kinda like that this one is reasonably bulletproof
There was a problem hiding this comment.
Also no strong opinion but I like doing this as part of "--write-locks" as people already expect their version numbers to change through this run.
There was a problem hiding this comment.
yeah, in general I hate it when i open intellij and something crucial is missing because it failed to generate somehow. this seemed more idiot dan-proof
|
Released 3.51.0 |
Before this PR
@fawind is putting in a bunch of work to allow people to use some more 'cutting edge' java syntax (e.g. records). Checkstyle seems to be landing a lot of bugfixes related to these new features at the moment, e.g.
https://checkstyle.sourceforge.io/releasenotes.html
Currently, as the checkstyle version is read out of a private static field, it has to be manually updated. This means we're probably going to miss bugfixes until someone complains about them.
After this PR
==COMMIT_MSG==
checkstyle 8.36 -> 8.37, to benefit from some bugfixes to do with new java language features (e.g. records)
==COMMIT_MSG==
Possible downsides?