Add baseline-encoding plugin to force UTF-8 during compilation #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Jan 5, 2021
| @Override | ||
| public void apply(Project project) { | ||
| project.getTasks().withType(JavaCompile.class).configureEach(t -> { | ||
| t.getOptions().setEncoding("UTF-8"); |
There was a problem hiding this comment.
nit: would prefer to rename t -> compileJavaTask
carterkozak
approved these changes
Jan 5, 2021
pkoenig10
force-pushed
the
pkoenig/utf8
branch
from
850d003 to
ccb6d69
Compare
pkoenig10
force-pushed
the
pkoenig/utf8
branch
from
27046b1 to
aa6baf4
Compare
pkoenig10
commented
Jan 5, 2021
| then: | ||
| BuildResult result = with('compileJava').build() | ||
| result.task(":compileJava").outcome == TaskOutcome.SUCCESS | ||
| result.output.contains("unmappable character") |
There was a problem hiding this comment.
Compilation doesn't actually fail when encountering unmappable characters - those characters are just replaced with the unicode replacement character.
|
Released 3.63.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
JavaCompiletasks use the platform charset by default. This is oftenUTF-8, but we have seen internal CI builds where the platform charset isUS_ASCII. This can lead to compilation failures if source files contains non-ASCII characters.After this PR
Baseline now provides a
baseline-encodingplugin that set the encoding toUTF-8for allJavaCompiletasks.