Preserve DOCTYPE in checkstyle.xml #1606
Conversation
Generate changelog in
|
| Authors: Robert Fink, Brian Worth, Merrick Zoubeiri, and many other contributors. Based in part on http://checkstyle.sourceforge.net/google_style.html | ||
| Please keep checks alphabetized with one exception: "relaxed" checks are grouped together at the bottom for easier disabling. | ||
| Check-specific comments reference documents internal to Palantir and can be safely ignored or removed. | ||
| --> |
There was a problem hiding this comment.
Removed this comment because it didn't write well - it ends up looking like:
<?xml version="1.0" encoding="UTF-8" standalone="no"?><!--
Palantir Baseline Checkstyle configuration.
Authors: Robert Fink, Brian Worth, Merrick Zoubeiri, and many other contributors. Based in part on http://checkstyle.sourceforge.net/google_style.html
Please keep checks alphabetized with one exception: "relaxed" checks are grouped together at the bottom for easier disabling.
Check-specific comments reference documents internal to Palantir and can be safely ignored or removed.
--><module name="Checker">
This comment isn't particularly useful. In particular, the checks are no longer alphabetized.
There was a problem hiding this comment.
I'd prefer not to make this change in the same PR as a bugfix.
There was a problem hiding this comment.
Are you opposed to the change? I'm happy to make another PR, but if you're just going to approve that one it seems a bit silly.
I probably should have removed this in #1603.
There was a problem hiding this comment.
I don't really have an opinion one way or the other on the comment.
|
Released 3.63.3 |
Before this PR
The XML parsing/writing logic added in #1603 doesn't preserve the DOCTYPE. This causes the
checkstyleMainCircleFinalizertask to fail.https://app.circleci.com/pipelines/github/palantir/gradle-baseline/1699/workflows/2623eafb-018b-41d4-bd1f-9fb2e6511f37/jobs/23047
After this PR
Preserve the DOCTYPE when writing the checkstyle XML.