Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude internal ImmutablesStyle annotations from auto-imports and completion #1668

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

pkoenig10
Copy link
Member

These ImmutablesStyle annotations should not be public, but doing so would be a breaking change.

To prevent continued accidental usage, prevent them from being automatically imported or appearing in completion results.

@changelog-app
Copy link

changelog-app bot commented Mar 5, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Internal ImmutablesStyle annotations are now excluded from Intellij auto-imports and completion.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from jkozlowski March 5, 2021 17:21
@pkoenig10 pkoenig10 requested a review from CRogers March 5, 2021 17:22
Copy link
Contributor

@CRogers CRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@carterkozak
Copy link
Contributor

Can we excavate folks to the canonical internal annotation?

@pkoenig10
Copy link
Member Author

Agree that excavating this change would be ideal.

However it isn't trivial for a couple reasons:

  • It may required adding a dependency on our internal immutables-style project
  • The annotations are not quite equivalent. It probably won't matter in most cases, but it can result in some unintended side-effects.
    • Most notably the overshadowImplementation and get options are different on the different annotations.

@bulldozer-bot bulldozer-bot bot merged commit 772d52d into develop Mar 5, 2021
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/ignore branch March 5, 2021 17:33
@svc-autorelease
Copy link
Collaborator

Released 3.70.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants