Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferImmutableStreamExCollections is disabled by default #1681

Merged
merged 2 commits into from
Mar 8, 2021
Merged

PreferImmutableStreamExCollections is disabled by default #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c0ef0
PreferImmutableStreamExCollections is disabled by default
carterkozak Mar 8, 2021
8b039f3
Add generated changelog entries
carterkozak Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1681.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: PreferImmutableStreamExCollections is disabled by default
links:
- https://github.com/palantir/gradle-baseline/pull/1681
1 change: 0 additions & 1 deletion ...ne-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ public class BaselineErrorProneExtension {
// TODO(ckozak): re-enable pending scala check
// "ThrowSpecificity",
"UnsafeGaugeRegistration",
"PreferImmutableStreamExCollections",

// Built-in checks
"ArrayEquals",
Expand Down
6 changes: 5 additions & 1 deletion gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,11 @@ private static void configureErrorProneOptions(
: CheckSeverity.OFF;
}));

errorProneOptions.disable("AutoCloseableMustBeClosed", "CatchSpecificity", "UnusedVariable");
errorProneOptions.disable(
"AutoCloseableMustBeClosed",
"CatchSpecificity",
"PreferImmutableStreamExCollections",
"UnusedVariable");
errorProneOptions.error(
"EqualsHashCode",
"EqualsIncompatibleType",
Expand Down