Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ProxyNonConstantType to WARNING (from suggestion) #1816

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Upgrade ProxyNonConstantType to WARNING (from suggestion) #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c915e4
Upgrade ProxyNonConstantType to WARNING (from suggestion)
carterkozak Jun 29, 2021
ba0abbe
Add generated changelog entries
svc-changelog Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...line-error-prone/src/main/java/com/palantir/baseline/errorprone/ProxyNonConstantType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
name = "ProxyNonConstantType",
link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
linkType = LinkType.CUSTOM,
severity = SeverityLevel.SUGGESTION,
severity = SeverityLevel.WARNING,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how many repos have hit this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few will hit it hard, most don't hit it at all. I suppressed the warning in WC where we hit it on an old retrofit codepath.

summary = "Proxy instances should be created using constant types known at compile time to allow native-image "
+ "behavior to match hotspot. Methods which build proxies should take a "
+ "`Function<InvocationHandler, ? extends T>` instead of arbitrary class references. "
Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1816.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Upgrade ProxyNonConstantType to WARNING (from suggestion)
links:
- https://github.com/palantir/gradle-baseline/pull/1816