Fix formatting of baseline-class-uniqueness.lock files #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there was more than one configuration, a newline was missing between the previous configuration and the comment naming the next one.
Generate changelog in
|
carterkozak
approved these changes
Jul 22, 2021
This was referenced Jul 22, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 22, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.2.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Support the new SafeLogger API | palantir/gradle-baseline#1834 | | Improvement | Fix the formatting of `baseline-class-uniqueness.lock` files when more than one configuration is listed. A newline was missing. This may require running `./gradlew checkClassUniqueness --write-locks` to update the files. | palantir/gradle-baseline#1838 | ## 4.3.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Allow `PreferSafeLogger` to migrate logger uses which include level-checks | palantir/gradle-baseline#1842 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 22, 2021
This was referenced Jul 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1289
Before this PR
When the baseline class uniqueness check found issues in more than one configuration, a newline was missing between the previous configuration and the comment naming the next one. See: #1289
After this PR
==COMMIT_MSG==
Fix the formatting of
baseline-class-uniqueness.lockfiles when more than one configuration is listed. A newline was missing. This may require running./gradlew checkClassUniqueness --write-locksto update the files.==COMMIT_MSG==
Possible downsides?
Requires running the command to write the locks in repos that are affected. (By default only one configuration is set up for the uniqueness check, so the number of affected repos may be small.) I'm not sure if this would be considered a break.