Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDoc uses UTF-8 encoding #1879

Merged
merged 2 commits into from
Aug 15, 2021
Merged

JavaDoc uses UTF-8 encoding #1879

merged 2 commits into from
Aug 15, 2021

Conversation

schlosna
Copy link
Contributor

Before this PR

See palantir/tritium#1192 where JavaDoc is failing to generate on system using default US-ASCII encoding

After this PR

==COMMIT_MSG==
JavaDoc uses UTF-8 encoding by default
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Aug 15, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

JavaDoc uses UTF-8 encoding by default

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@bulldozer-bot bulldozer-bot bot merged commit 42e1597 into develop Aug 15, 2021
@bulldozer-bot bulldozer-bot bot deleted the ds/encoding branch August 15, 2021 19:29
@svc-autorelease
Copy link
Collaborator

Released 4.16.0

This was referenced Aug 15, 2021
This was referenced Aug 15, 2021
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Aug 17, 2021
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.14.0
_Automated release, no documented user facing changes_

## 4.15.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Automatically fix upstream `LoopOverCharArray` | palantir/gradle-baseline#1873 |


## 4.16.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | JavaDoc uses UTF-8 encoding by default | palantir/gradle-baseline#1879 |


## 4.17.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Enforce `PreferSafeLogger` at `WARNING` level matching `Slf4jLogsafeArgs` and `PreferSafeLoggingPreconditions`. This doesn't apply to gradle plugins. | palantir/gradle-baseline#1876 |



To enable or disable this check, please contact the maintainers of Excavator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants