-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add null check for exclude rule #1883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
Aug 18, 2021
Released 4.19.0 |
This was referenced Aug 18, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Aug 18, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.19.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Re-add null check for exclude rule | palantir/gradle-baseline#1883 | ## 4.20.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix missing setProperty error when using Gradle 6 | palantir/gradle-baseline#1884 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Aug 18, 2021
This was referenced Aug 18, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We removed this null-check in #1875 because intellij flags this as
However this does not seem to be true and an internal library failed to upgrade because
rule.getGroup()
returns null.Stacktrace:
After this PR
==COMMIT_MSG==
Re-add null check for exclude rule
==COMMIT_MSG==