-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safety data-flow #2143
Merged
+1,503
−94
Merged
Safety data-flow #2143
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
942ad3f
extract safety
carterkozak ed96f83
Implement simple data flow
carterkozak b9c10ef
style
carterkozak 6338721
cleaner
carterkozak 620df75
Add generated changelog entries
svc-changelog 9c54518
cleaner
carterkozak 09ccf68
simplify
carterkozak da30ac5
test
carterkozak 174e2db
validate return statements
carterkozak 37cd8e3
simpler safety-analysis api
carterkozak 37e6aa0
handle polymorphism
carterkozak 3ebe697
nulls
carterkozak 16c4e3b
link upstream
carterkozak ae9d375
remove unnecessary suppression
carterkozak 472f54d
review feedback
carterkozak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
nulls
commit 3ebe69704f667230cede78e24348e1f77599647b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
visitWideningConversion
andvisitNarrowingConversion
uses the same code. Maybe we can extract or delegate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll include
visitTypeCast
as well