Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dependency bump which prevented some tests from running #2433

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

carterkozak
Copy link
Contributor

#2432 should not pass tests, the NullAway integration test should definitely fail here.

==COMMIT_MSG==
Revert a dependency bump to run all tests once again
==COMMIT_MSG==

Also fix up JooqResultStreamLeakTest which appears to have never worked, using incorrect junit annotations.

Revert "Excavator:  Upgrade dependencies (#2342)"

This reverts commit 2c966d9.
@carterkozak carterkozak requested a review from schlosna October 13, 2022 18:08
@carterkozak carterkozak changed the title Ckozak/fix tests Revert dependency bump which prevented some tests from running Oct 13, 2022
@carterkozak carterkozak merged commit aab0545 into develop Oct 13, 2022
@schlosna schlosna deleted the ckozak/fix_tests branch October 14, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant