-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding inclusive language standards to the README #2446
Conversation
This PR accompanies #2425, which adds inclusive language standards as a checkstyle rule.
README.md
Outdated
@@ -254,6 +254,32 @@ in `.baseline/copyright/*.txt`. The largest file (sorted lexicographically) will | |||
|
|||
To automatically update all files with mismatching/missing copyrights, run `./gradlew format`. | |||
|
|||
### Inclusive Language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on moving this to fit into https://github.com/palantir/gradle-baseline/tree/develop/docs/best-practices/java-coding-guidelines
It's not java-specific, but otherwise I think that's a reasonable place for guidelines to live (where this won't describe a specific check, but rather our guidance which will future checks may enforce)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new file in that directory that isn't specific to java could also work nicely, though a bit harder for folks to discover. I defer to your judgement :-]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea! moved them to a new file in that directory and linked from the best practices readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll update the top-level readme with information about the checkstyle enforcement in that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
For now, this PR simply adds our inclusive standards as a best practice. In the future, we will enforce these standards as a checkstyle rule.
DEI and Legal have approved this.