Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding inclusive language standards to the README #2446

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

lsingh123
Copy link
Contributor

@lsingh123 lsingh123 commented Nov 4, 2022

For now, this PR simply adds our inclusive standards as a best practice. In the future, we will enforce these standards as a checkstyle rule.

DEI and Legal have approved this.

This PR accompanies #2425, which
adds inclusive language standards as a checkstyle rule.
@lsingh123 lsingh123 marked this pull request as draft November 4, 2022 19:23
@lsingh123 lsingh123 requested a review from carterkozak November 4, 2022 19:23
README.md Outdated
@@ -254,6 +254,32 @@ in `.baseline/copyright/*.txt`. The largest file (sorted lexicographically) will

To automatically update all files with mismatching/missing copyrights, run `./gradlew format`.

### Inclusive Language
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on moving this to fit into https://github.com/palantir/gradle-baseline/tree/develop/docs/best-practices/java-coding-guidelines
It's not java-specific, but otherwise I think that's a reasonable place for guidelines to live (where this won't describe a specific check, but rather our guidance which will future checks may enforce)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new file in that directory that isn't specific to java could also work nicely, though a bit harder for folks to discover. I defer to your judgement :-]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea! moved them to a new file in that directory and linked from the best practices readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll update the top-level readme with information about the checkstyle enforcement in that PR.

@lsingh123 lsingh123 changed the title WIP - adding inclusive language standards to the README adding inclusive language standards to the README Nov 4, 2022
@lsingh123 lsingh123 marked this pull request as ready for review January 12, 2023 16:10
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bulldozer-bot bulldozer-bot bot merged commit b89a62e into develop Feb 28, 2023
@bulldozer-bot bulldozer-bot bot deleted the lsingh/add-inclusive-language-readme branch February 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants