-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseline-immutables handles annotationProcessor configuration extendsFrom #2465
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Released 4.185.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.185.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Ensure that `baseline-immutables` configures immutables to work incrementally when the immutables `annotationProcessor` dependency is not a direct dependency (ie it is brought in transitively or by an `extendsFrom`). | palantir/gradle-baseline#2465 | To enable or disable this check, please contact the maintainers of Excavator.
Before this PR
Internally, someone had written the code:
in their repo. They then only put the immutables processor in
annotationProcessor
, but nottestAnnotationProcessor
:The plugin currently only checks dependencies declared directly in the configuration. This means the
test
source set had immutables, but was not configuring it to be incremental, meaning that the iteration loop for tests was a 2 min full compile.Additionally, the current plugin does not handle the case where immutables would be brought in transitively.
After this PR
==COMMIT_MSG==
Ensure that
baseline-immutables
configures immutables to work incrementally when the immutablesannotationProcessor
dependency is not a direct dependency (ie it is brought in transitively or by anextendsFrom
).==COMMIT_MSG==
Possible downsides?