Upgrade error_prone to 2.18.0 (from 2.16) #2472
Conversation
Generate changelog in
|
|
Stumbled upon this as we we're hitting google/error-prone#2321 on an internal repo. The fix is in 2.17.0 but not sure if that is any easier to merge. |
carterkozak
force-pushed
the
ckozak/error_prone_2_18_0
branch
from
55c7ab1 to
8b22954
Compare
| @Inject | ||
| public LogsafeArgName(ErrorProneFlags flags) { |
There was a problem hiding this comment.
Caught by InjectOnBugCheckers in 2.18.0.
| @@ -52,6 +52,9 @@ allprojects { | |||
| check("PreferSafeLogger", CheckSeverity.OFF) | |||
| check("PreferSafeLoggingPreconditions", CheckSeverity.OFF) | |||
| check("PreconditionsConstantMessage", CheckSeverity.OFF) | |||
| // temporarily opt out of error-prone in order to upgrade checkerframework. | |||
| // This should be removed as soon as baseline is next upgraded within this repo. | |||
| enabled = false | |||
There was a problem hiding this comment.
I've compiled this using a snapshot of itself, things seem good, the problem is upgrading dependencies makes our existing baseline classes (applied to this project) incompatible with the upgraded checkerframework.
There was a problem hiding this comment.
This flag has been removed with the baseline upgrade here: https://github.com/palantir/gradle-baseline/pull/2503/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7L55-L57
| "Varifier"); | ||
| "Varifier", | ||
| // Yoda style should not block baseline upgrades. | ||
| "YodaCondition"); |
There was a problem hiding this comment.
There are a few new 🌶️ checkers, I would bet on AvoidObjectArrays, Finalize, YodaCondition likely need some manual intervention/suppression upon rollout (though in general I think we want those checks enabled)
2.17:
AvoidObjectArrays
Finalize
IgnoredPureGetter
ImpossibleNullComparison
MathAbsoluteNegative
NewFileSystem
StatementSwitchToExpressionSwitch
UnqualifiedYield
2.18:
InjectOnBugCheckers
LabelledBreakTarget
UnusedLabel
YodaCondition
|
Released 4.189.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.189.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Upgrade error_prone to 2.18.0 (from 2.16) | palantir/gradle-baseline#2472 | ## 4.190.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | Added `DangerousCollapseKeysUsage` error prone check to disallow usage of `collapseKeys()` API of `EntryStream`. | palantir/gradle-baseline#2291 | | Feature | Prefer common versions of annotations over other copies | palantir/gradle-baseline#2505 | To enable or disable this check, please contact the maintainers of Excavator.
==COMMIT_MSG==
Upgrade error_prone to 2.18.0 (from 2.16)
==COMMIT_MSG==
Possible downsides?
New checks added in https://github.com/google/error-prone/releases/tag/v2.17.0 and https://github.com/google/error-prone/releases/tag/v2.18.0 may prevent upgrades from auto-merging.