ensure tasks that use moduleJvmArgs have task inputs set correctly #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BaselineModuleJvmArgs plugin configures several tasks from the 'java' plugin to use values from the 'moduleJvmArgs' extension (e.g. to update compiler arguments, output values to the jar manifest, etc.). However, when the value on the extension changes, those tasks are not re-run. To fix that, add input properties for each task that uses moduleJvmArgs so that when the extension value changes, the task will no longer be up-to-date. Fixes #2476
Generate changelog in
|
bulldozer-bot
bot
deleted the
blaub/set-task-inputs-from-BaselineModuleJvmArgs
branch
|
Released 4.186.0 |
This was referenced Jan 30, 2023
Merged
This was referenced Jan 30, 2023
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 30, 2023
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.186.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | add input properties for each task that uses moduleJvmArgs so that when the extension value changes, the task will no longer be up-to-date. | palantir/gradle-baseline#2477 | ## 4.187.0 _No documented user facing changes_ To enable or disable this check, please contact the maintainers of Excavator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaselineModuleJvmArgs plugin configures several tasks from the 'java' plugin to use values from the 'moduleJvmArgs' extension (e.g. to update compiler arguments, output values to the jar manifest, etc.). However, when the value on the extension changes, those tasks are not re-run.
To fix that, add input properties for each task that uses moduleJvmArgs so that when the extension value changes, the task will no longer be up-to-date.
Fixes #2476
Before this PR
The BaselineModuleJvmArgs plugin configures several tasks from the 'java' plugin to use values from the 'moduleJvmArgs' extension (e.g. to update compiler arguments, output values to the jar manifest, etc.). However, when the value on the extension changes, those tasks are not re-run.
After this PR
==COMMIT_MSG==
add input properties for each task that uses moduleJvmArgs so that when the extension value changes, the task will no longer be up-to-date.
==COMMIT_MSG==
Possible downsides?