Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify error-prone refactoring code #2843

Closed
wants to merge 2 commits into from

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Aug 20, 2024

Before this PR

Now we've upgraded to recent errorprone, there are some workarounds we had for bugs that are no longer necessary. Now that google/error-prone#3908 is fixed (and released in 2.26.0) we can avoid explicitly disabling checks when patching.

After this PR

==COMMIT_MSG==
Simplify error-prone refactoring code
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Aug 20, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Simplify error-prone refactoring code

Check the box to generate changelog(s)

  • Generate changelog entry

Comment on lines -193 to -199
// Work around https://github.com/google/error-prone/issues/3908 by explicitly enabling any
// check we want to use patch checks for (ensuring it is not disabled); if this is fixed, the
// -Xep:*:ERROR arguments could be removed
return Iterables.concat(
errorProneChecks.stream()
.map(checkName -> "-Xep:" + checkName + ":ERROR")
.collect(Collectors.toList()),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this change to fail this test, but it is actually working 🤔

Copy link
Contributor Author

@CRogers CRogers Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests in BaselineErrorProneIntegrationTest are very broken, they still pass if you stop disabling the checks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall some configuration ordering issues where checks may be configured before the gradle-baseline defaults are applied and override error-prone settings

@CRogers CRogers closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants