baseline-error-prone targets jdk-17+

[carterkozak]

==COMMIT_MSG==
baseline-error-prone targets jdk-17+
==COMMIT_MSG==

Risk is that we lose errorprone support for projects targeting jdk11, where we use a jdk11 for compilation.
In those cases, failure modes range from silently ignoring error-prone to build failures. Given that we do not support jdk11 anymore, this is a reasonable risk.

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

baseline-error-prone targets jdk-17+

Check the box to generate changelog(s)

• Generate changelog entry

[pkoenig10]

@carterkozak what would it take to merge this? This is blocking the Error Prone upgrade in #2982, which is blocking some upgrades due to the typical:

• Error Prone break their API (google/error-prone@3b16d61)
• Guava upgrades to this version of Error Prone (google/guava@cf508b7)
• Another Error Prone checks library upgrades to this version of Guava
• Upgrading these custom Error Prone check libraries in consumers fails with java.lang.NoSuchMethodError: 'boolean com.google.errorprone.util.ASTHelpers.isRuleKind(com.sun.source.tree.CaseTree)'

As of 2.33.0, Error Prone requires compiling using Java 17.

https://github.com/google/error-prone/releases/tag/v2.33.0

It seems like com.palantir.baseline-java-versions doesn't support using a newer compiler to target older versions, which is what Error Prone requires.

[pkoenig10]

Should we consider not auto-upgrading Guava in Error Prone check repos? This is not the first time this specific failure mode has happened.

Invalidated by push of b31a57a

[autorelease3]

Released 6.6.0