One more assertj refaster #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Sep 24, 2019
| public final class AssertjCollectionHasSameSizeAs<T,U> { | ||
|
|
||
| @BeforeTemplate | ||
| IterableAssert<T> before(IterableAssert<T> assertInProgress, List<U> expected) { |
There was a problem hiding this comment.
List can be Collection
There was a problem hiding this comment.
Iterable doesn't have the .size() method, so I used Collection initially, but I can't even get my test to pass with this :/
Currently dying in RefasterScanner - think I may have borked my IDE a bit. Might try again tomorrow!
There was a problem hiding this comment.
I think refaster requires an exact match on the assert type returned by AssertThat:
This should work:
@BeforeTemplate
ListAssert<T> before(ListAssert<T> assertInProgress, Collection<U> expected) {
return assertInProgress.hasSize(expected.size());
}However it won't apply to collections or iterable targerrs
There was a problem hiding this comment.
Based on #881 it may or may not work in java 11...
|
Closing out because I can't get this to work and it doesn't seem that high value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I saw a codebase with exactly this before state, which can easily be replaced with a version that produces a nicer error message!
After this PR
==COMMIT_MSG==
refaster replacement for assertj hasSize(foo.size) -> hasSameSizeAs
==COMMIT_MSG==
Possible downsides?
n/a