-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 8 fixes #1401
Gradle 8 fixes #1401
Conversation
Generate changelog in
|
gradle-conjure/src/main/java/com/palantir/gradle/conjure/ConjurePlugin.java
Show resolved
Hide resolved
@@ -663,12 +684,10 @@ private static <T> Set<T> mutableSetWithExtraEntry(Set<T> set, T extraItem) { | |||
|
|||
static TaskProvider<WriteGitignoreTask> createWriteGitignoreTask( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These write gitignore tasks are also causing task dep validation errors. Maybe not this one specifically, but there are some more internally that also have problems as they get included into source jars without the dependsOn
Released 5.43.0 |
Before this PR
The way
gradle-conjure
generates files means that it will run into implicit dependency errors. This was happening in conjure.After this PR
==COMMIT_MSG==
Set up correct dependencies for Gradle 8.
==COMMIT_MSG==
Key points:
src/generated/java
, we havebuild/generated/sources/conjure-<type>/main/java
build/generated/sources/annotationProcessor/java/main
./gradlew idea
or./gradlew eclipse
depends on the umbrella task, but each subproject taskPossible downsides?
Hard to migrate python/typescript/other sources, as I don't know how they are consumed and that would be a break. In fairness the existing code had set up idea to do the wrong thing to them anyway but I imagine people will want to keep stuff in source. This may not fix us for the implicit dependency if we're running into the python/ts errors in