Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8 fixes #1401

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Gradle 8 fixes #1401

merged 4 commits into from
Mar 21, 2024

Conversation

felixdesouza
Copy link
Contributor

Before this PR

The way gradle-conjure generates files means that it will run into implicit dependency errors. This was happening in conjure.

After this PR

==COMMIT_MSG==
Set up correct dependencies for Gradle 8.
==COMMIT_MSG==

Key points:

  • Instead of using a static directory, use the output of the generator task for the source set
  • Set the output to be different for each generator task (java):
    • so instead of src/generated/java, we have build/generated/sources/conjure-<type>/main/java
    • This mirrors what gradle do with annotation processors: build/generated/sources/annotationProcessor/java/main
  • Separate out the ide tasks so that running ./gradlew idea or ./gradlew eclipse depends on the umbrella task, but each subproject task

Possible downsides?

Hard to migrate python/typescript/other sources, as I don't know how they are consumed and that would be a break. In fairness the existing code had set up idea to do the wrong thing to them anyway but I imagine people will want to keep stuff in source. This may not fix us for the implicit dependency if we're running into the python/ts errors in

@changelog-app
Copy link

changelog-app bot commented Mar 21, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Set up correct dependencies for Gradle 8.

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -663,12 +684,10 @@ private static <T> Set<T> mutableSetWithExtraEntry(Set<T> set, T extraItem) {

static TaskProvider<WriteGitignoreTask> createWriteGitignoreTask(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These write gitignore tasks are also causing task dep validation errors. Maybe not this one specifically, but there are some more internally that also have problems as they get included into source jars without the dependsOn

@bulldozer-bot bulldozer-bot bot merged commit affee43 into develop Mar 21, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the gradle-8-fixes branch March 21, 2024 16:16
@svc-autorelease
Copy link
Collaborator

Released 5.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants