Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable javaLanucher for test task #460

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

FinlayRJW
Copy link
Contributor

@FinlayRJW FinlayRJW commented Sep 18, 2024

Before this PR

Test tasks for intellij plugins would cause the following error:

Toolchain from `executable` property does not match toolchain from `javaLauncher` property.

After this PR

This commit works around that issue

@changelog-app
Copy link

changelog-app bot commented Sep 18, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

disable javaLanucher for test task

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers
Copy link
Contributor

CRogers commented Sep 18, 2024

I think it's worth putting the error message in the PR description at least, for future people's understanding.

@CRogers
Copy link
Contributor

CRogers commented Sep 18, 2024

👍

@bulldozer-bot bulldozer-bot bot merged commit 850d992 into develop Sep 18, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the finlayw/update_intellij_publish branch September 18, 2024 11:57
@autorelease3
Copy link

autorelease3 bot commented Sep 18, 2024

Released 1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants