Rename check & setupJdks to disambiguate task shortcuts #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
crogoz
commented
Oct 31, 2024
| @@ -127,7 +127,7 @@ public void apply(Project rootProject) { | |||
| .named(LifecycleBasePlugin.CHECK_TASK_NAME) | |||
| .configure(check -> check.dependsOn(checkJdksLifecycle)); | |||
|
|
|||
| rootProject.getTasks().register("setupJdks", SetupJdksTask.class, setupJdksTask -> { | |||
| rootProject.getTasks().register("setupGradleJdks", SetupJdksTask.class, setupJdksTask -> { | |||
There was a problem hiding this comment.
changed the name for consistency
There was a problem hiding this comment.
do you have to change things in the intellij plugin?
There was a problem hiding this comment.
Isn't this going to break excavators?
There was a problem hiding this comment.
Isn't this going to break excavators?
you are right, thanks for catching this! I reverted this rename.
do you have to change things in the intellij plugin?
the intellij plugin is calling directly the gradle-jdks-setup.sh script
CRogers
approved these changes
Oct 31, 2024
|
Released 0.53.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Context: https://pl.ntr/2pc
Users were using
gw cJto run the compileJava task.checkJavais now matching this shortcut as well.After this PR
Change task names to disambiguate used shortcuts
==COMMIT_MSG==
Rename check & setupJdks to disambiguate task shortcuts
==COMMIT_MSG==
Possible downsides?