-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle JDK Automanagements writes output to stderr #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
reviewed
Nov 12, 2024
# inserting the lines from gradle-jdks/src/main/resources/gradlew-patch.sh | ||
PLACEHOLDER_INSERT_GRADLEW_PATCH | ||
|
||
echo "JAVA_HOME is set to: $JAVA_HOME" | ||
|
||
# running again Gradle JDKs setup, won't write anything to stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
CRogers
previously approved these changes
Nov 12, 2024
policy-bot
bot
dismissed
CRogers’s stale review
November 12, 2024 13:17
Invalidated by push of e5fed0b
👍 |
bulldozer |
Released 0.56.0 |
svc-excavator-bot
pushed a commit
to svc-excavator-bot-org/gradle-jdks
that referenced
this pull request
Jan 7, 2025
Gradle JDK Automanagements writes output to stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We would write the output logs when running "./gradlew" with Gradle jdk automanagement to stdOut. This broke some behavior https://pl.ntr/2pt that was relying on reading the stdout of a task.
After this PR
All outputs written by the Gradle JDK automanagement workflow will be sent to stderr. These logs are considered diagnostic messages.
==COMMIT_MSG==
Gradle JDK Automanagements writes output to stderr
==COMMIT_MSG==
Possible downsides?