Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle JDK Automanagements writes output to stderr #461

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

crogoz
Copy link
Contributor

@crogoz crogoz commented Nov 12, 2024

Before this PR

We would write the output logs when running "./gradlew" with Gradle jdk automanagement to stdOut. This broke some behavior https://pl.ntr/2pt that was relying on reading the stdout of a task.

After this PR

All outputs written by the Gradle JDK automanagement workflow will be sent to stderr. These logs are considered diagnostic messages.
==COMMIT_MSG==
Gradle JDK Automanagements writes output to stderr
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Nov 12, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Gradle JDK Automanagements writes output to stderr

Check the box to generate changelog(s)

  • Generate changelog entry

@crogoz crogoz requested a review from CRogers November 12, 2024 12:50
# inserting the lines from gradle-jdks/src/main/resources/gradlew-patch.sh
PLACEHOLDER_INSERT_GRADLEW_PATCH

echo "JAVA_HOME is set to: $JAVA_HOME"

# running again Gradle JDKs setup, won't write anything to stdout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

CRogers
CRogers previously approved these changes Nov 12, 2024
@policy-bot policy-bot bot dismissed CRogers’s stale review November 12, 2024 13:17

Invalidated by push of e5fed0b

@crogoz crogoz requested a review from CRogers November 12, 2024 13:31
@CRogers
Copy link
Contributor

CRogers commented Nov 12, 2024

👍

@CRogers
Copy link
Contributor

CRogers commented Nov 12, 2024

bulldozer

@bulldozer-bot bulldozer-bot bot merged commit f13e635 into develop Nov 12, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the cr/write-to-stderr branch November 12, 2024 18:14
@autorelease3
Copy link

autorelease3 bot commented Nov 12, 2024

Released 0.56.0

svc-excavator-bot pushed a commit to svc-excavator-bot-org/gradle-jdks that referenced this pull request Jan 7, 2025
Gradle JDK Automanagements writes output to stderr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants