Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle JDK installation directory contains glibc/musl name for linux distributions #482

Merged
merged 13 commits into from
Dec 12, 2024

Conversation

crogoz
Copy link
Contributor

@crogoz crogoz commented Dec 12, 2024

Before this PR

Context: https://pl.ntr/2pU
Excavator caches the location of gradle-jdks directory, however it doesn't take into consideration if the job is running on a musl/glibc image. Without this, we might be using the jdk used for a different c implementation.
In that case, when we were trying to access the java executable for a different c implementation, we were getting:

root@excavator-worker...:/local/.gradle/gradle-jdks/amazon-corretto-17.0.13.11.1/bin# ./java
bash: ./java: No such file or directory

After this PR

Local-path jdk installation directory contains for linux distros also the c implementation type: glibc/musl. This will avoid the caching issue in excavator.

==COMMIT_MSG==
Gradle JDK installation directory contains glibc/musl name for linux distributions
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Dec 12, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Gradle JDK installation directory contains glibc/musl name for linux distributions

Check the box to generate changelog(s)

  • Generate changelog entry

@crogoz crogoz requested a review from CRogers December 12, 2024 15:07
@crogoz crogoz force-pushed the cr/include-glibc-or-musl branch from 59692d9 to 3d875aa Compare December 12, 2024 16:43
@bulldozer-bot bulldozer-bot bot merged commit 03d06ac into develop Dec 12, 2024
5 of 6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the cr/include-glibc-or-musl branch December 12, 2024 16:47
@autorelease3
Copy link

autorelease3 bot commented Dec 12, 2024

Released 0.59.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants