Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport buffer re-use (#561) to 2.x #576

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

dtobin
Copy link

@dtobin dtobin commented Oct 7, 2021

Before this PR

The 3.0.0 release includes a breaking upgrade to Hadoop 3.x. We want to backport the buffer re-use fix from #561 to 2.x so that consumers unable to upgrade their Hadoop version can pick up the fix.

After this PR

==COMMIT_MSG==
Reduce byte[] allocations during reads via ApacheCtrDecryptingSeekableInput
==COMMIT_MSG==

Possible downsides?

@dtobin dtobin requested review from ellisjoe and carterkozak October 7, 2021 17:37
@dtobin
Copy link
Author

dtobin commented Oct 7, 2021

@carterkozak @ellisjoe I don't have admin permissions on the repo to perform the autorelease - will need help with that. Let me know if there is a convention for release branch naming.

@ellisjoe ellisjoe merged commit 3fbd456 into release/2.x Oct 20, 2021
@ellisjoe ellisjoe deleted the dtobin/backport-reuse-buffer branch October 20, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants