Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace some glassfish osgi bundles with java ee equivalents #110

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

bjlaub
Copy link
Contributor

@bjlaub bjlaub commented Oct 26, 2023

No description provided.

@bjlaub bjlaub requested a review from carterkozak October 26, 2023 18:04
@changelog-app
Copy link

changelog-app bot commented Oct 26, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

replace some glassfish osgi bundles with java ee equivalents

Check the box to generate changelog(s)

  • Generate changelog entry

"org.glassfish.hk2.external:javax.inject",
new VersionMapping(
new MavenCoordinate("org.glassfish.hk2.external", "javax.inject", "2.4.0"),
new MavenCoordinate("javax.inject", "javax.inject", "1")));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other libraries auto-resolved by the other plugin which aren't handled here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other one would be the el-api things, but it actually goes in the opposite direction (el-api replaced with org.glassfish:jakarta.el).

I'm inclined to leave that one alone, it's not as straighforward since the jakarta.el implementation contains more than just the classes in el-api, whereas with inject it should be the same set of classes.

@bulldozer-bot bulldozer-bot bot merged commit e7acb3d into develop Oct 30, 2023
@bulldozer-bot bulldozer-bot bot deleted the blaub/replace-osgi-repackaged-inject branch October 30, 2023 17:15
@svc-autorelease
Copy link
Collaborator

Released 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants