Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect against other types of erroneous versions #28

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

bjlaub
Copy link
Contributor

@bjlaub bjlaub commented Feb 9, 2023

No description provided.

@changelog-app
Copy link

changelog-app bot commented Feb 9, 2023

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

protect against other types of erroneous versions

Check the box to generate changelog(s)

  • Generate changelog entry

@bjlaub bjlaub requested a review from carterkozak February 9, 2023 19:53

class VersionMappingsTest {
@Test
public void testBogusVersions() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary public modifier, probably worth a new error-prone rule+excavator to handle this sort of thing more broadly when I have some cycles.

Suggested change
public void testBogusVersions() {
void testBogusVersions() {

Copy link

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@bulldozer-bot bulldozer-bot bot merged commit 02811fb into develop Feb 9, 2023
@bulldozer-bot bulldozer-bot bot deleted the blaub/fix-bug-again branch February 9, 2023 20:00
@svc-autorelease
Copy link
Collaborator

Released 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants