Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Excavator: Upgrades Baseline to the latest version #62

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Sep 20, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.4.1

Type Description Link
Fix Avoid false positives caused by module-info.class when checking class uniqueness palantir/gradle-baseline#823

2.4.2

Type Description Link
Fix Checkstyle tasks only check their own source set and only actual java sources. They don't look in your src/*/resources directory anymore. palantir/gradle-baseline#830

2.4.3

Type Description Link
Fix Add link to StrictUnusedVariable that directs users to baseline repo. palantir/gradle-baseline#829
Fix Long try-with-resources statements are now aligned such that the first assignment stays on the first line. palantir/gradle-baseline#835

2.5.0

Type Description Link
Improvement Error Prone StringBuilderConstantParameters. StringBuilder with a constant number of parameters should be replaced by simple concatenation. The Java compiler (jdk8) replaces concatenation of a constant number of arguments with a StringBuilder, while jdk 9+ take advantage of JEP 280 (https://openjdk.java.net/jeps/280) to efficiently pre-size the result for better performance than a StringBuilder. palantir/gradle-baseline#832

2.6.0

Type Description Link
Fix Excavator PRs that apply other refaster rules (e.g. Witchcraft ones) will not also apply baseline refaster rules. palantir/gradle-baseline#827
Improvement Added a new ErrorProne check PreferAssertj to assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency on org.assertj:assertj-core in modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used, PreferAssertj may be explicitly disabled to prevent future upgrades from attempting to re-run the migration. palantir/gradle-baseline#841

2.7.0

Type Description Link
Improvement StrictUnusedVariable now ignores variables prefixed with _ and the suggested fix will rename all unused parameters in public methods instead of removing them palantir/gradle-baseline#833
Improvement ErrorProne will now detect dangerous usage of @RunWith(Suite.class) that references JUnit5 classes, as this can cause tests to silently not run! palantir/gradle-baseline#843

2.8.0

Type Description Link
Fix PreferAssertj provides better replacements fixes palantir/gradle-baseline#850
Improvement Do not run error prone on any code in the build directory palantir/gradle-baseline#853

2.8.1

Type Description Link
Fix Fix hamcrest arrayContainingInAnyOrder conversion palantir/gradle-baseline#859

2.9.0

Type Description Link
Improvement StrictUnusedVariable can only be suppressed with _ prefix palantir/gradle-baseline#854
Improvement StrictUnusedVariable is now an error by default palantir/gradle-baseline#855
Fix The PreferAssertj refactoring will only be applied if you have explicitly opted in (e.g. using baselineErrorProne { patchChecks += 'PreferAssertj' } palantir/gradle-baseline#861

2.9.1

Type Description Link
Fix Error prone will correctly ignore all source files in the build directory and in any generated source directory palantir/gradle-baseline#864
Fix Ensure that StrictUnusedVariable correctly converts previously suppressed variables unused to _ palantir/gradle-baseline#865

2.9.2

Type Description Link
Fix When removing unused variables, StrictUnusedVariable will preserve side effects palantir/gradle-baseline#870

2.10.0

Type Description Link
Improvement A new checkJUnitDependencies task detects misconfigured JUnit dependencies which could result in some tests silently not running. palantir/gradle-baseline#837
Improvement Some AssertJ assertions can now be automatically replaced with more idiomatic ones using refaster. palantir/gradle-baseline#851
Fix PreferAssertj check avoids ambiguity in assertThat invocations palantir/gradle-baseline#874
Improvement Improve performannce of error prone PreferAssertj check palantir/gradle-baseline#875
Improvement StringBuilderConstantParameters suggested fix doesn't remove comments palantir/gradle-baseline#877

2.10.1

Type Description Link
Fix Allow junit4 dependencies to exist without junit4 tests palantir/gradle-baseline#880

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from a4a4f9e to e3ae956 Compare September 24, 2019 00:27
@bulldozer-bot bulldozer-bot bot merged commit 493dc4d into develop Sep 24, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch September 24, 2019 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants