Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DnsCacheTtl accessors #309

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Implement DnsCacheTtl accessors #309

merged 4 commits into from
Apr 30, 2024

Conversation

carterkozak
Copy link
Contributor

Implement DnsCacheTtl accessors

@changelog-app
Copy link

changelog-app bot commented Apr 30, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Implement DnsCacheTtl accessors

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot dismissed andybradshaw’s stale review April 30, 2024 16:10

Invalidated by push of 522ffdc

Copy link
Contributor

@bjlaub bjlaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bulldozer-bot bulldozer-bot bot merged commit ba6fb99 into develop Apr 30, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/DnsCacheTtl branch April 30, 2024 16:13
@svc-autorelease
Copy link
Collaborator

Released 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants