Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric-schema includes the java version by default as a javaVersion tag #832

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Aug 2, 2022

Before this PR

It was difficult to tie changes in performance or stability to a particular java release due to lack of data association.

After this PR

Note that I biased toward safety, excluding the new tag in cases where a javaVersion tag is already defined to avoid impacting existing dashboards, allowing upgrades to flow seamlessly.

==COMMIT_MSG==
metric-schema includes the java version by default as a javaVersion tag, for example javaVersion:17.0.3
==COMMIT_MSG==

Possible downsides?

Reported metrics are slightly larger, but the cardinality is unchanged.
System property load on class initialization isn't quite as nice as loading the java version once in a library and referencing it elsewhere, however this isn't going to be meaningful overall.

I'd considered adding this data in the reporting layer, however by adding it higher up in the process, it's clearer what data we produce.

@changelog-app
Copy link

changelog-app bot commented Aug 2, 2022

Generate changelog in changelog/@unreleased

Type
See change types. Select one:

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

metric-schema includes the java version by default as a javaVersion tag, for example javaVersion:17.0.3

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit d460ee1 into develop Aug 2, 2022
@bulldozer-bot bulldozer-bot bot deleted the ckozak/javaVersion branch August 2, 2022 21:45
@svc-autorelease
Copy link
Collaborator

Released 0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants