metric-schema includes the java version by default as a javaVersion
tag
#832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
It was difficult to tie changes in performance or stability to a particular java release due to lack of data association.
After this PR
Note that I biased toward safety, excluding the new tag in cases where a
javaVersion
tag is already defined to avoid impacting existing dashboards, allowing upgrades to flow seamlessly.==COMMIT_MSG==
metric-schema includes the java version by default as a
javaVersion
tag, for examplejavaVersion:17.0.3
==COMMIT_MSG==
Possible downsides?
Reported metrics are slightly larger, but the cardinality is unchanged.
System property load on class initialization isn't quite as nice as loading the java version once in a library and referencing it elsewhere, however this isn't going to be meaningful overall.
I'd considered adding this data in the reporting layer, however by adding it higher up in the process, it's clearer what data we produce.