Spotless plugin #107
Merged
Spotless plugin #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…lugin w/o spotless on the classpath
|
It's sad that gradle-palantir-java-format now has to depend on the spotless plugin (not compileOnly), but this seems to be the only straightforward way to configure that plugin. |
|
Update: was able to make it work with compileOnly - it's trickier to set this up when testing, but when using the plugin, since all the dependencies are resolved together, this will just work. |
CRogers
approved these changes
Dec 13, 2019
|
Released 0.3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Logic for how to format a project with PJF is coupled between palantir-java-format and gradle-baseline.
This makes it hard for users to apply the formatter gradle plugin directly, because it needs the wiring from
com.palantir.baseline-formatto actually set up all the formatting tasks.After this PR
==COMMIT_MSG==
Move spotless configuration logic into a new plugin
com.palantir.java-format-spotless. The maincom.palantir.java-formatplugin now applies both the spotless and idea plugins too.==COMMIT_MSG==
Possible downsides?