-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't always inline expression lambdas #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Holding off on this for a bit until we can determine how many changes it will cause in a large internal repo. |
iamdanfox
approved these changes
Jan 29, 2020
# Conflicts: # palantir-java-format/src/main/java/com/palantir/javaformat/doc/Level.java
Released 0.3.19 |
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We always allow an inlining to stop at a lambda, regardless of the complexity of the expression following the lambda.
This can sometimes lead to inlining a bunch of arguments but breaking up a super simple lambda, which is not readable at all:
After this PR
==COMMIT_MSG==
More strictly control when we can inline a chunk of code followed by an expression lambda.
Specifically, the inlining chain now continues through to the body of the expression lambda, with the exception that the inlined expression so far is reset to be considered "simple" when entering a lambda expression.
The exception is necessary in order to preserve the inlining of palantir-chains-lambdas which we consider desirable.
==COMMIT_MSG==
Example changes on:
Possible downsides?
I think this is acceptable as long as the existing code doesn't become less readable but just a bit more sparse, if in return we get rid of some corner cases that were extremely unreadable / confusing.