Respect user's existing splits in string concatenations #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Feb 13, 2020
| } | ||
|
|
||
| private static final Pattern FORMAT_SPECIFIER = Pattern.compile("%|\\{[0-9]\\}"); | ||
|
|
||
| private boolean isStringConcat(ExpressionTree first) { | ||
| final boolean[] stringConcat = {false}; |
There was a problem hiding this comment.
ah yes, the poor man's AtomicBoolean 😂
iamdanfox
reviewed
Feb 13, 2020
palantir-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
Outdated
Show resolved
Hide resolved
iamdanfox
reviewed
Feb 13, 2020
palantir-java-format/src/main/java/com/palantir/javaformat/OpsBuilder.java
Outdated
Show resolved
Hide resolved
iamdanfox
reviewed
Feb 13, 2020
...ntir-java-format/src/test/resources/com/palantir/javaformat/java/testdata/palantir-10.output
Show resolved
Hide resolved
iamdanfox
approved these changes
Feb 13, 2020
|
🐞 |
|
Released 0.3.24 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We'd split long string concatenations such that we'd end up with one item per line.
This breaks carefully crafted Sql statements in annotations or other places.
After this PR
==COMMIT_MSG==
Preserve the user's newlines in a long string concatenation (defined as a concatenation with
+where at least one expression is a literal string).Also allow inlining annotation values.
==COMMIT_MSG==
Possible downsides?
cc @sixinli