Fix crash when breaking up long comment after simple lambda body #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
A long comment that follows an otherwise simple lambda body (no inner levels) can cause a crash if it ends up being chunked onto multiple lines by the
CommentsHelper
.After this PR
==COMMIT_MSG==
Make lambda/assignment logic more resilient so it doesn't crash when encountering long comments.
==COMMIT_MSG==
Possible downsides?
This currently means that if the lambda / assignment body is not complex but has a long comment which doesn't fit on one line, the body will always end up on the 2nd line:
If this is not desirable, we could revert the heuristic to what it was before, but be resilient in the next method down the line
tryInlinePrefixOntoCurrentLine
so we don't crash if no inner level is found.