Java CLI to format parts of files based on git diff #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
One of the main goals of this whole endeavour is to make excavator code-changes pass checkstyle. To achieve this, we don't actually need to reformat people's entire projects, just ensure that the PRs we make have nice linebreaks, don't go past 120 chars etc.
(Full adoption of the formatter everywhere comes with its own benefits, but it's almost orthogonal).
After this PR
==COMMIT_MSG==
The
FormatDiffCli
class reads the output ofgit diff -U0
and runs the formatter on modified lines only.==COMMIT_MSG==
The plan is to run this from a gradle task in baseline, and conceivably even as a pre-commit hook!! (Here's the original python one)
Possible downsides?