-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correctly support Intellij 193+ #51
Conversation
I think there might be a better way of hooking into CodeStyleManager than replacing it... The impl seems to have logic that delegates to an
|
Update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved modulo manual testing
Smoke-tested and was still able to format files on my IntelliJ!
|
Before this PR
Loading
CodeStyleManager
programmatically in a way that is not (really) supported in IntelliJ builds 193 and up.It kind of works, but keeps throwing a lot of errors.
After this PR
==COMMIT_MSG==
Get rid of constant error in new Intellij 193 by replacing
CodeStyleManager
via aplugin.xml
-declared service override, rather than programmatically using internal APIs.==COMMIT_MSG==
Got the idea here: google/google-java-format#404 (comment)
Fixes #50
Possible downsides?
not entirely sure this works on previous versions, need to double checkworks at least on 191.5849.21META-INF/LangExtensions.xml