Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #59

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 1, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.28.0

Type Description Link
Improvement Implement FinalClass error prone check, replacing the checkstyle implementation palantir/gradle-baseline#1008
Improvement Error prone validation to avoid redundant modifiers palantir/gradle-baseline#1010

2.28.1

Type Description Link
Fix Fix RedundantModifier interpretation of implicit modifiers palantir/gradle-baseline#1014

2.28.2

Type Description Link
Fix Fix RedundantModifier failures types nested in interfaces palantir/gradle-baseline#1017

2.28.3

Type Description Link
Fix Fix error-prone mathcing literal null as a subtype.
The most common issue this fixes is failures on SafeArg.of("name", null)
assuming that the null literal value parameter may be a throwable.
palantir/gradle-baseline#1020

2.29.0

Type Description Link
Improvement Error prone RedundantModifier check supports interface static methods and fields. palantir/gradle-baseline#1021
Fix Ignore module-info.java files to support projects with Jigsaw. palantir/gradle-baseline#1023
Improvement Error Prone StrictCollectionIncompatibleType to guard collection usage palantir/gradle-baseline#1027
Improvement Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
palantir/gradle-baseline#1028

2.30.0

Type Description Link
Improvement InvocationHandlers which delegate to another object must catch and unwrap
InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown
each time the delegate throws an exception.
palantir/gradle-baseline#1032

To enable or disable this check, please contact the maintainers of Excavator.

@policy-bot policy-bot bot requested a review from iamdanfox November 1, 2019 18:54
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 6 times, most recently from b120d05 to bf8095c Compare November 7, 2019 19:04
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from bf8095c to 20d007c Compare November 11, 2019 21:10
@bulldozer-bot bulldozer-bot bot merged commit 5245770 into develop Nov 12, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch November 12, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants