Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Publish gradle plugin to gradle plugin portal #731

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

robert3005
Copy link
Contributor

@robert3005 robert3005 commented Apr 28, 2022

Before this PR

After this PR

==COMMIT_MSG==
Publish gradle plugin to gradle plugin portal
==COMMIT_MSG==

Possible downsides?

@iamdanfox
Copy link
Contributor

iamdanfox commented Apr 28, 2022

IIRC the :palantir-java-format-spi was a blocker to successfully publishing to the gradle plugin portal... dan had this originally: #24

@robert3005
Copy link
Contributor Author

I really care that the gradle plugin markers are published so I could just turn on automatedpublishing and not do the rest

@robert3005
Copy link
Contributor Author

eh, this should just work as the spi is published as a library

@iamdanfox
Copy link
Contributor

Actually I think the problem before was that using the plugins {} syntax had a hard-coded list of repositories that it would try to load jars from, and our old bintray thing was obviously not one of them... given that we're now publishing to MavenCentral, maybe this is no longer a problem??

Think this is worth a shot, but will defer the final +1 to a current infra team member.

@robert3005
Copy link
Contributor Author

you can always add a repo under pluginManagement in settings.gradle

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bulldozer-bot bulldozer-bot bot merged commit 50c8b25 into develop Apr 28, 2022
@bulldozer-bot bulldozer-bot bot deleted the rk/publish branch April 28, 2022 19:30
@svc-autorelease
Copy link
Collaborator

Released 2.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants