Use bootstrapping formatter starting from Intellij 2022.2 #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Starting with version 2022.2, Intellij now runs with JDK 17 (release notes). This breaks the formatter because when running with JDK 15+, it requires respective
--add-exportargs to be set.The current workaround is to manually add the missing
--add-exportflags to the Intellij runtime JDK (see this related issue: google/google-java-format#787 (comment)).After this PR
To avoid having to manually add the
--add-exportflags to the Intellij runtime JDK, we always use the bootstrapping formatter when running with Intellij 2022.2 or higher.==COMMIT_MSG==
Use bootstrapping formatter starting from Intellij 2022.2
==COMMIT_MSG==
Possible downsides?
Running the bootstrapping formatter adds some lag to each formatting action and e.g. formatting a whole project is currently quite slow. However given that we already use this codepath for all projects using JDK 15 or higher, this seems okay.