Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise imports on save #906

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Jul 25, 2023

Before this PR

In #862, we moved away from using the "Save Actions" plugin to using the native IntelliJ "Actions on Save" feature.

An oversight when doing this was that the Save Actions plugin was configured to use optimise imports as well. However, in #862 we did not enable optimise on save.

This mostly flew under the radar as most devs have manually enabled the "Optimize Imports on the Fly" option in intellij at soe point in the last $years, and this mostly fixes the inputs for you as you code. However, some devs do not have this, especially devs who are new or are low code who are least equipped to resolve this problem.

After this PR

==COMMIT_MSG==
Ensure imports are optimised on save, as well as formatting.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from felixdesouza July 25, 2023 16:25
@changelog-app
Copy link

changelog-app bot commented Jul 25, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Ensure imports are optimised on save, as well as formatting.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit d7304d3 into develop Jul 25, 2023
@bulldozer-bot bulldozer-bot bot deleted the callumr/optimise-imports-on-save branch July 25, 2023 16:30
@svc-autorelease
Copy link
Collaborator

Released 2.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants