-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't always break at method calls with prefix #94
Conversation
Generate changelog in
|
Shall we do a preview on c-j-r and see what we get?? |
Preconditions.checkArgument( | ||
hostPortString.charAt(0) == '[', | ||
"Bracketed host-port string must start with a bracket", | ||
SafeArg.of("port", hostPortString)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
Example changes compared to 0.3.2: |
Released 0.3.4 |
@dansanduleac would you mind picking this up in gradle-baseline and getting a release of that out too pls? |
Before this PR
We were allowing the inlining logic to stop (accept an inlining) whenever the last "level" (in most cases, argument to a method call) was a dotted construction (like a method call chain) that contains a prefix which PJF would want to keep on one line (
SafeArg.of
being the most prevalent case of this).This would cause degenerate formattings like:
After this PR
==COMMIT_MSG==
Stop indiscriminately stopping an inlining at method calls like
SafeArg.of
.==COMMIT_MSG==
Possible downsides?