Fix "Could not determine jdk version for project" error #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
AlexLandau
reviewed
Jan 13, 2024
idea-plugin/src/main/java/com/palantir/javaformat/intellij/FormatterProvider.java
Show resolved
Hide resolved
CRogers
reviewed
Jan 15, 2024
| int indexOfVersionDelimiter = version.indexOf('.'); | ||
| String normalizedVersion = | ||
| indexOfVersionDelimiter >= 0 ? version.substring(0, indexOfVersionDelimiter) : version; | ||
| normalizedVersion = normalizedVersion.replaceAll("-ea", ""); | ||
| try { | ||
| return Integer.parseInt(normalizedVersion); | ||
| return OptionalInt.of(Integer.parseInt(normalizedVersion)); | ||
| } catch (NumberFormatException e) { | ||
| log.error("Could not parse sdk version: {}", version, e); | ||
| return null; |
There was a problem hiding this comment.
Returning null for an OptionalInt here seems not ideal.
There was a problem hiding this comment.
Whoops! Fixed, and filed #987 to enable baseline-null-away on this repo
|
👍 |
|
Released 2.40.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979
Before this PR
See linked issue.
I think this is happening because
ProjectRootManager.getInstance(project).getProjectSdk()here is sometimes returningnull. This is allowed by its method contract (there is a@Nullablemarking on the method), so we need to handle it gracefully.After this PR
==COMMIT_MSG==
Fix "Could not determine jdk version for project" error
==COMMIT_MSG==
With this PR, I intend for palantir-java-format to handle this situation by logging a warning and not performing any formatting.
Possible downsides?
If this state persists indefinitely, users may find that formatting no longer works and no longer have the warning in their IDE pointing in this direction. Users rarely view IDE warning logs (in fact I had to search for how to find them when researching for this PR).