-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow inlining method calls if current inlining is simple #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
approved these changes
Dec 6, 2019
Would kinda like to have the specific test case from fforms that prompted this checked in! |
🚂 |
Released 0.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
#63 fixed a degenerate case where
SafeArg.of(
and other similarX.y(
method calls could end up with their parameters on a new line, even if this was just an argument that was part of a long method call with other arguments.Unfortunately, this fix also broke a bunch of situations that were relying on this inlining logic, and whose code consequently blew up to many many levels of indentation, breaking the 120 character limit.
After this PR
==COMMIT_MSG==
Bring back inlining the prefix of method calls iff the levels inlined so far have all been simple.
By simple, in practice we mean a single method call (rather than chained method calls), or a single method parameter. This is defined as a property on the Level
OpenOp
s created inJavaInputAstVisitor
.==COMMIT_MSG==
Possible downsides?