Merge pull request #123 from jamesross3/jross/deprecate-subregistry

Deprecate Subregistry method on the RootRegistry interface.
palantir · Nov 10, 2018 · 163672d · 163672d
2 parents b5d51c0 + 4a05653
commit 163672d
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/metrics/registry.go b/metrics/registry.go
@@ -51,6 +51,8 @@ type RootRegistry interface {
 	// Subregistry returns a new subregistry of the root registry on which metrics can be registered.
 	//
 	// Specified tags will be always included in metrics emitted by a subregistry.
+	// Deprecated: Use metrics.FromContext(ctx) instead to get a child registry with tags. Using subregistries and metric names
+	// to namespace metrics is discouraged; metric tags should handle this instead.
 	Subregistry(prefix string, tags ...Tag) Registry
 }